Commit c5128654 authored Dec 05, 2013 by Emmanuel Grumbach

iwlwifi: mvm: don't allow A band if SKU forbids it



The driver wasn't reading the NVM properly. While this
didn't lead to any issue until now, it seems that there
is an old version of the NVM in the wild.
In this version, the A band channels appear to be valid
but the SKU capabilities (another field of the NVM) says
that A band isn't supported at all.
With this specific version of the NVM, the driver would
think that A band is supported while the HW / firmware
don't. This leads to asserts.

Cc: <stable@vger.kernel.org> [3.10+]
Reviewed-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>

parent 8e2a866e

drivers/net/wireless/iwlwifi/iwl-nvm-parse.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -182,6 +182,11 @@ static int iwl_init_channel_map(struct device dev, const struct iwl_cfg cfg,

		for (ch_idx = 0; ch_idx < IWL_NUM_CHANNELS; ch_idx++) {
		ch_flags = __le16_to_cpup(nvm_ch_flags + ch_idx);

		if (ch_idx >= NUM_2GHZ_CHANNELS &&
		!data->sku_cap_band_52GHz_enable)
		ch_flags &= ~NVM_CHANNEL_VALID;

		if (!(ch_flags & NVM_CHANNEL_VALID)) {
		IWL_DEBUG_EEPROM(dev,
		"Ch. %d Flags %x [%sGHz] - No traffic\n",