Commit c4a2d7fb authored Jul 04, 2008 by Michael Halcrow Committed by Linus Torvalds Jul 04, 2008

ecryptfs: remove unnecessary mux from ecryptfs_init_ecryptfs_miscdev()



The misc_mtx should provide all the protection required to keep the daemon
hash table sane during miscdev registration.  Since this mutex is causing
gratuitous lockdep warnings, this patch removes it.

Signed-off-by: Michael Halcrow <mhalcrow@us.ibm.com>
Reported-by: Cyrill Gorcunov <gorcunov@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 10dd08dc

fs/ecryptfs/miscdev.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -575,13 +575,11 @@ int ecryptfs_init_ecryptfs_miscdev(void)
		int rc;

		atomic_set(&ecryptfs_num_miscdev_opens, 0);
		mutex_lock(&ecryptfs_daemon_hash_mux);
		rc = misc_register(&ecryptfs_miscdev);
		if (rc)
		printk(KERN_ERR "%s: Failed to register miscellaneous device "
		"for communications with userspace daemons; rc = [%d]\n",
		__func__, rc);
		mutex_unlock(&ecryptfs_daemon_hash_mux);
		return rc;
		}