Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c4082941 authored by Vikram Mulukutla's avatar Vikram Mulukutla Committed by Pavankumar Kondeti
Browse files

sched: qhmp_core: Fix possible hotplug race in set_cpus_allowed_ptr 



Since a CPU may go offline after cpu_active_mask is used
to query active CPUs, set_cpus_allowed_ptr might inadverntently
pass an invalid cpu number to move_queued_task.

Fix this by ensuring that the cpumask op that uses cpu_active_mask
checks the return value.

CRs-Fixed: 1029014
Change-Id: Iab49c8140a00b8b644f5b4f6c87e2e298a8bb107
Signed-off-by: default avatarVikram Mulukutla <markivx@codeaurora.org>
Signed-off-by: default avatarPavankumar Kondeti <pkondeti@codeaurora.org>
parent fbf8878a

kernel/sched/qhmp_core.c

+2 −2
Original line number Diff line number Diff line
@@ -6596,7 +6596,8 @@ int set_cpus_allowed_ptr(struct task_struct *p, const struct cpumask *new_mask) 
	if (cpumask_equal(&p->cpus_allowed, new_mask))

		goto out;



	if (!cpumask_intersects(new_mask, cpu_active_mask)) {

	dest_cpu = cpumask_any_and(cpu_active_mask, new_mask);

	if (dest_cpu >= nr_cpu_ids) {

		ret = -EINVAL;

		goto out;

	}
@@ -6607,7 +6608,6 @@ int set_cpus_allowed_ptr(struct task_struct *p, const struct cpumask *new_mask) 
	if (cpumask_test_cpu(task_cpu(p), new_mask))

		goto out;



	dest_cpu = cpumask_any_and(cpu_active_mask, new_mask);

	if (task_running(rq, p) || p->state == TASK_WAKING) {

		struct migration_arg arg = { p, dest_cpu };

		/* Need help from migration thread: drop lock and wait. */