Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c3688957 authored by Sarada Prasanna Garnayak's avatar Sarada Prasanna Garnayak Committed by Sudhakar Manapati
Browse files

input: synaptics_i2c_rmi4: Turn off the reset gpio before freeing it. 



Set the direction of reset GPIO to input before freeing it. This
eliminates any leakage current which may be there.

This patch is propagated from msm-3.10 kernel
(commit: c894e4be06913adb73be7157f986602ea6991414
input: synaptics_i2c_rmi4: Turn off the reset gpio before freeing it.)
Also cleaned checkpatch warning on msm-3.18 kernel.

CRs-Fixed: 553847
Change-Id: Ib439de058326bf0d14d6e18b0a6198b4f682daf8
Signed-off-by: default avatarSarada Prasanna Garnayak <c_sgarna@codeaurora.org>
Signed-off-by: default avatarSudhakar Manapati <smanap@codeaurora.org>
parent 7d54fbdb

drivers/input/touchscreen/synaptics_i2c_rmi4.c

+23 −6
Original line number Diff line number Diff line
@@ -2653,13 +2653,30 @@ static int synaptics_rmi4_gpio_configure(struct synaptics_rmi4_data *rmi4_data, 
			synaptics_rmi4_reset_command(rmi4_data);



		return 0;

	}

	} else {

		if (rmi4_data->board->disable_gpios) {

			if (gpio_is_valid(rmi4_data->board->irq_gpio))

				gpio_free(rmi4_data->board->irq_gpio);

		if (gpio_is_valid(rmi4_data->board->reset_gpio))

			if (gpio_is_valid(rmi4_data->board->reset_gpio)) {

				/*

				 * This is intended to save leakage current

				 * only. Even if the call(gpio_direction_input)

				 * fails, only leakage current will be more but

				 * functionality will not be affected.

				 */

				retval = gpio_direction_input(rmi4_data->

							board->reset_gpio);

				if (retval) {

					dev_err(&rmi4_data->i2c_client->dev,

					"unable to set direction for gpio ",

					"[%d]\n", rmi4_data->board->irq_gpio);

				}

				gpio_free(rmi4_data->board->reset_gpio);

			}

		}



		return 0;

	}



	return 0;