Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c3485dd4 authored by Pavankumar Kondeti's avatar Pavankumar Kondeti Committed by Gerrit - the friendly Code Review server
Browse files

sched/cputime: fix a deadlock on 32bit systems



cpu_hardirq_time and cpu_softirq_time are protected with
seqlock on 32bit systems. There is a potential deadlock
with this seqlock and rq->lock.

CPU 1                             CPU0
==========================        ========================
--> acquire CPU0 rq->lock         --> __irq_enter()
----> task enqueue/dequeue        ----> irqtime_account_irq()
------> update_rq_clock()         ------> irq_time_write_begin()
--------> irq_time_read()         --------> sched_account_irqtime()
(waiting for the seqlock          (waiting for the CPU0 rq->lock)
held in irq_time_write_begin()

Fix this issue by dropping the seqlock before calling
sched_account_irqtime()

Change-Id: I29a33876e372f99435a57cc11eada9c8cfd59a3f
Signed-off-by: default avatarPavankumar Kondeti <pkondeti@codeaurora.org>
parent 1cba7830
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment