Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c31558ef authored by Julia Lawall's avatar Julia Lawall Committed by James Bottomley
Browse files

[SCSI] fusion: Move a dereference below a NULL test

If the NULL test is necessary, then the dereference should be moved below
the NULL test.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/

).

// <smpl>
@disable is_null@
identifier f;
expression E;
identifier fld;
statement S;
@@

+ if (E == NULL) S
  f(...,E->fld,...);
- if (E == NULL) S

@@
identifier f;
expression E;
identifier fld;
statement S;
@@

+ if (!E) S
  f(...,E->fld,...);
- if (!E) S
// </smpl>

Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Acked-by: default avatar"Prakash, Sathya" <Sathya.Prakash@lsi.com>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
parent ddccf307
Loading
Loading
Loading
Loading
+3 −2
Original line number Diff line number Diff line
@@ -308,10 +308,11 @@ static void mptctl_timeout_expired (MPT_IOCTL *ioctl)
{
	int rc = 1;

	dctlprintk(ioctl->ioc, printk(MYIOC_s_DEBUG_FMT ": Timeout Expired! Host %d\n",
				ioctl->ioc->name, ioctl->ioc->id));
	if (ioctl == NULL)
		return;
	dctlprintk(ioctl->ioc,
		   printk(MYIOC_s_DEBUG_FMT ": Timeout Expired! Host %d\n",
		   ioctl->ioc->name, ioctl->ioc->id));

	ioctl->wait_done = 0;
	if (ioctl->reset & MPTCTL_RESET_OK)