Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c2f88b17 authored by Sagi Grimberg's avatar Sagi Grimberg Committed by Nicholas Bellinger
Browse files

Target/iser: Get isert_conn reference once got to connected_handler 



In case the connection didn't reach connected state, disconnected
handler will never be invoked thus the second kref_put on
isert_conn will be missing.

Signed-off-by: default avatarSagi Grimberg <sagig@mellanox.com>
Cc: <stable@vger.kernel.org> # v3.10+
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent 9e82bf01

drivers/infiniband/ulp/isert/ib_isert.c

+3 −2
Original line number Diff line number Diff line
@@ -586,7 +586,6 @@ isert_connect_request(struct rdma_cm_id *cma_id, struct rdma_cm_event *event) 
	init_completion(&isert_conn->conn_wait);

	init_completion(&isert_conn->conn_wait_comp_err);

	kref_init(&isert_conn->conn_kref);

	kref_get(&isert_conn->conn_kref);

	mutex_init(&isert_conn->conn_mutex);

	spin_lock_init(&isert_conn->conn_lock);

	INIT_LIST_HEAD(&isert_conn->conn_fr_pool);
@@ -746,7 +745,9 @@ isert_connect_release(struct isert_conn *isert_conn) 
static void

isert_connected_handler(struct rdma_cm_id *cma_id)

{

	return;

	struct isert_conn *isert_conn = cma_id->context;



	kref_get(&isert_conn->conn_kref);

}



static void