Commit c2f3f3a2 authored Jun 17, 2009 by françois romieu Committed by David S. Miller Jun 17, 2009

sis190: use an adequate phy list entry as a fallback

When sis190 driver is trying to get default phy, if it doesn't find home
or lan phy, it falls back to the first phy in the phy list but list_entry()
points to a bogus entry. list_first_entry() should be used instead.

Signed-off-by: Arnaud Patard <apatard@mandriva.com>
Acked-off-by: Francois Romieu <romieu@fr.zoreil.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent fb1001f3

drivers/net/sis190.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1281,7 +1281,7 @@ static u16 sis190_default_phy(struct net_device *dev)
		else if (phy_lan)
		phy_default = phy_lan;
		else
		phy_default = list_entry(&tp->first_phy,
		phy_default = list_first_entry(&tp->first_phy,
		struct sis190_phy, list);
		}