Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c262e001 authored by Chao Yu's avatar Chao Yu Committed by Jaegeuk Kim
Browse files

f2fs: clean up with is_valid_blkaddr() 



- rename is_valid_blkaddr() to is_valid_meta_blkaddr() for readability.
- introduce is_valid_blkaddr() for cleanup.

No logic change in this patch.

Signed-off-by: default avatarChao Yu <yuchao0@huawei.com>
Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
parent 8a0a325d

fs/f2fs/checkpoint.c

+2 −2
Original line number Diff line number Diff line
@@ -120,7 +120,7 @@ struct page *get_tmp_page(struct f2fs_sb_info *sbi, pgoff_t index) 
	return __get_meta_page(sbi, index, false);

}



bool is_valid_blkaddr(struct f2fs_sb_info *sbi, block_t blkaddr, int type)

bool is_valid_meta_blkaddr(struct f2fs_sb_info *sbi, block_t blkaddr, int type)

{

	switch (type) {

	case META_NAT:
@@ -176,7 +176,7 @@ int ra_meta_pages(struct f2fs_sb_info *sbi, block_t start, int nrpages, 
	blk_start_plug(&plug);

	for (; nrpages-- > 0; blkno++) {



		if (!is_valid_blkaddr(sbi, blkno, type))

		if (!is_valid_meta_blkaddr(sbi, blkno, type))

			goto out;



		switch (type) {

fs/f2fs/data.c

+5 −13
Original line number Diff line number Diff line
@@ -485,7 +485,7 @@ next: 
		spin_unlock(&io->io_lock);

	}



	if (fio->old_blkaddr != NEW_ADDR)

	if (is_valid_blkaddr(fio->old_blkaddr))

		verify_block_addr(fio, fio->old_blkaddr);

	verify_block_addr(fio, fio->new_blkaddr);
@@ -1052,7 +1052,7 @@ next_dnode: 
next_block:

	blkaddr = datablock_addr(dn.inode, dn.node_page, dn.ofs_in_node);



	if (blkaddr == NEW_ADDR || blkaddr == NULL_ADDR) {

	if (!is_valid_blkaddr(blkaddr)) {

		if (create) {

			if (unlikely(f2fs_cp_error(sbi))) {

				err = -EIO;
@@ -1662,15 +1662,6 @@ static inline bool need_inplace_update(struct f2fs_io_info *fio) 
	return should_update_inplace(inode, fio);

}



static inline bool valid_ipu_blkaddr(struct f2fs_io_info *fio)

{

	if (fio->old_blkaddr == NEW_ADDR)

		return false;

	if (fio->old_blkaddr == NULL_ADDR)

		return false;

	return true;

}



int do_write_data_page(struct f2fs_io_info *fio)

{

	struct page *page = fio->page;
@@ -1685,7 +1676,7 @@ int do_write_data_page(struct f2fs_io_info *fio) 
			f2fs_lookup_extent_cache(inode, page->index, &ei)) {

		fio->old_blkaddr = ei.blk + page->index - ei.fofs;



		if (valid_ipu_blkaddr(fio)) {

		if (is_valid_blkaddr(fio->old_blkaddr)) {

			ipu_force = true;

			fio->need_lock = LOCK_DONE;

			goto got_it;
@@ -1712,7 +1703,8 @@ got_it: 
	 * If current allocation needs SSR,

	 * it had better in-place writes for updated data.

	 */

	if (ipu_force || (valid_ipu_blkaddr(fio) && need_inplace_update(fio))) {

	if (ipu_force || (is_valid_blkaddr(fio->old_blkaddr) &&

					need_inplace_update(fio))) {

		err = encrypt_one_page(fio);

		if (err)

			goto out_writepage;

fs/f2fs/f2fs.h

+8 −1
Original line number Diff line number Diff line
@@ -2780,6 +2780,13 @@ static inline void f2fs_update_iostat(struct f2fs_sb_info *sbi, 
	spin_unlock(&sbi->iostat_lock);

}



static inline bool is_valid_blkaddr(block_t blkaddr)

{

	if (blkaddr == NEW_ADDR || blkaddr == NULL_ADDR)

		return false;

	return true;

}



/*

 * file.c

 */
@@ -2998,7 +3005,7 @@ void f2fs_stop_checkpoint(struct f2fs_sb_info *sbi, bool end_io); 
struct page *grab_meta_page(struct f2fs_sb_info *sbi, pgoff_t index);

struct page *get_meta_page(struct f2fs_sb_info *sbi, pgoff_t index);

struct page *get_tmp_page(struct f2fs_sb_info *sbi, pgoff_t index);

bool is_valid_blkaddr(struct f2fs_sb_info *sbi, block_t blkaddr, int type);

bool is_valid_meta_blkaddr(struct f2fs_sb_info *sbi, block_t blkaddr, int type);

int ra_meta_pages(struct f2fs_sb_info *sbi, block_t start, int nrpages,

			int type, bool sync);

void ra_meta_pages_cond(struct f2fs_sb_info *sbi, pgoff_t index);

fs/f2fs/file.c

+1 −1
Original line number Diff line number Diff line
@@ -355,7 +355,7 @@ static bool __found_offset(block_t blkaddr, pgoff_t dirty, pgoff_t pgofs, 
	switch (whence) {

	case SEEK_DATA:

		if ((blkaddr == NEW_ADDR && dirty == pgofs) ||

			(blkaddr != NEW_ADDR && blkaddr != NULL_ADDR))

			is_valid_blkaddr(blkaddr))

			return true;

		break;

	case SEEK_HOLE:

fs/f2fs/inode.c

+1 −1
Original line number Diff line number Diff line
@@ -72,7 +72,7 @@ static bool __written_first_block(struct f2fs_inode *ri) 
{

	block_t addr = le32_to_cpu(ri->i_addr[offset_in_addr(ri)]);



	if (addr != NEW_ADDR && addr != NULL_ADDR)

	if (is_valid_blkaddr(addr))

		return true;

	return false;

}