Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c21412f5 authored by Luis Alves's avatar Luis Alves Committed by Mauro Carvalho Chehab
Browse files

[media] Fixed misleading error when handling IR interrupts 



Hi,
Handling the AV Core/IR interrupts schedules its workqueue but
the schedule_work function returns false if @work was already on the
kernel-global workqueue and true otherwise.
Printing an error message if @work wasn't in the queue is wrong.
Regards,
Luis

Signed-off-by: default avatarLuis Alves <ljalvs@gmail.com>
Acked-by: default avatarAndy Walls <awalls@md.metrocast.net>
Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
parent a3fbba0e

drivers/media/pci/cx23885/cx23885-core.c

+1 −4
Original line number Diff line number Diff line
@@ -1941,10 +1941,7 @@ static irqreturn_t cx23885_irq(int irq, void *dev_id) 


	if ((pci_status & pci_mask) & PCI_MSK_AV_CORE) {

		cx23885_irq_disable(dev, PCI_MSK_AV_CORE);

		if (!schedule_work(&dev->cx25840_work))

			printk(KERN_ERR "%s: failed to set up deferred work for"

			       " AV Core/IR interrupt. Interrupt is disabled"

			       " and won't be re-enabled\n", dev->name);

		schedule_work(&dev->cx25840_work);

		handled++;

	}