Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c134fd86 authored by Maxim Shchetynin's avatar Maxim Shchetynin Committed by Benjamin Herrenschmidt
Browse files

powerpc/cell/edac: Log a syndrome code in case of correctable error 



If correctable error occurs the syndrome code was logged as 0. This patch
lets EDAC to log a correct syndrome code to make problem investigation
easier.

Signed-off-by: default avatarMaxim Shchetynin <maxim@de.ibm.com>
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Acked-by: default avatarDoug Thompson <dougthompson@xmission.com>
Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
parent 1ed6af73

drivers/edac/cell_edac.c

+3 −2
Original line number Diff line number Diff line
@@ -33,7 +33,7 @@ static void cell_edac_count_ce(struct mem_ctl_info *mci, int chan, u64 ar) 
{

	struct cell_edac_priv		*priv = mci->pvt_info;

	struct csrow_info		*csrow = &mci->csrows[0];

	unsigned long			address, pfn, offset;

	unsigned long			address, pfn, offset, syndrome;



	dev_dbg(mci->dev, "ECC CE err on node %d, channel %d, ar = 0x%016lx\n",

		priv->node, chan, ar);
@@ -44,10 +44,11 @@ static void cell_edac_count_ce(struct mem_ctl_info *mci, int chan, u64 ar) 
		address = (address << 1) | chan;

	pfn = address >> PAGE_SHIFT;

	offset = address & ~PAGE_MASK;

	syndrome = (ar & 0x000000001fe00000ul) >> 21;



	/* TODO: Decoding of the error addresss */

	edac_mc_handle_ce(mci, csrow->first_page + pfn, offset,

			  0, 0, chan, "");

			  syndrome, 0, chan, "");

}



static void cell_edac_count_ue(struct mem_ctl_info *mci, int chan, u64 ar)