Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c0cd6e5b authored by Rickard Strandqvist's avatar Rickard Strandqvist Committed by Greg Kroah-Hartman
Browse files

staging: bcm: nvm.c: Cleaning up check unsigned is less than zero 



Remove checking if a unsigned int is less than zero

This was found using a static code analysis program called cppcheck.

Signed-off-by: default avatarRickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent fa1e4a7f

drivers/staging/bcm/nvm.c

+2 −2
Original line number Diff line number Diff line
@@ -3321,7 +3321,7 @@ int BcmSetActiveSection(struct bcm_mini_adapter *Adapter, enum bcm_flash2x_secti 


			SectImagePriority = ReadISOPriority(Adapter, HighestPriISO) + 1;



			if ((SectImagePriority <= 0) && IsSectionWritable(Adapter, HighestPriISO)) {

			if ((SectImagePriority == 0) && IsSectionWritable(Adapter, HighestPriISO)) {

				/* This is a SPECIAL Case which will only happen if the current highest priority ISO has priority value = 0x7FFFFFFF.

				 * We will write 1 to the current Highest priority ISO And then shall increase the priority of the requested ISO

				 * by user
@@ -3381,7 +3381,7 @@ int BcmSetActiveSection(struct bcm_mini_adapter *Adapter, enum bcm_flash2x_secti 
			}



			SectImagePriority = ReadDSDPriority(Adapter, HighestPriDSD) + 1;

			if (SectImagePriority <= 0) {

			if (SectImagePriority == 0) {

				/* This is a SPECIAL Case which will only happen if the current highest priority DSD has priority value = 0x7FFFFFFF.

				 * We will write 1 to the current Highest priority DSD And then shall increase the priority of the requested DSD

				 * by user