Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c013d040 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

USB: Core: fix race in device_create 



There is a race from when a device is created with device_create() and
then the drvdata is set with a call to dev_set_drvdata() in which a
sysfs file could be open, yet the drvdata will be NULL, causing all
sorts of bad things to happen.

This patch fixes the problem by using the new function,
device_create_drvdata().

Cc: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent bfd3a5a9

drivers/usb/core/hcd.c

+3 −3
Original line number Diff line number Diff line
@@ -818,12 +818,12 @@ static int usb_register_bus(struct usb_bus *bus) 
	set_bit (busnum, busmap.busmap);

	bus->busnum = busnum;



	bus->dev = device_create(usb_host_class, bus->controller, MKDEV(0, 0),

	bus->dev = device_create_drvdata(usb_host_class, bus->controller,

					 MKDEV(0, 0), bus,

					 "usb_host%d", busnum);

	result = PTR_ERR(bus->dev);

	if (IS_ERR(bus->dev))

		goto error_create_class_dev;

	dev_set_drvdata(bus->dev, bus);



	/* Add it to the local list of buses */

	list_add (&bus->bus_list, &usb_bus_list);