Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bfaf40ad authored Oct 17, 2011 by Christoph Hellwig Committed by Nicholas Bellinger Oct 24, 2011

target: remove the TRANSPORT_REMOVE state



We never queue an command with this state, and only set it in a completely
bogus place in tcm_fc.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

parent 4499dda8

drivers/target/target_core_transport.c

+0 −3

Original line number	Original line	Diff line number	Diff line
	@@ -4787,9 +4787,6 @@ get_cmd:
	case TRANSPORT_COMPLETE_OK:		case TRANSPORT_COMPLETE_OK:
	transport_generic_complete_ok(cmd);		transport_generic_complete_ok(cmd);
	break;		break;
	case TRANSPORT_REMOVE:
	transport_put_cmd(cmd);
	break;
	case TRANSPORT_FREE_CMD_INTR:		case TRANSPORT_FREE_CMD_INTR:
	transport_generic_free_cmd(cmd, 0);		transport_generic_free_cmd(cmd, 0);
	break;		break;

drivers/target/tcm_fc/tfc_cmd.c

+0 −1

Original line number	Original line	Diff line number	Diff line
	@@ -267,7 +267,6 @@ static void ft_recv_seq(struct fc_seq sp, struct fc_frame fp, void *arg)

	if (IS_ERR(fp)) {		if (IS_ERR(fp)) {
	/* XXX need to find cmd if queued */		/* XXX need to find cmd if queued */
	cmd->se_cmd.t_state = TRANSPORT_REMOVE;
	cmd->seq = NULL;		cmd->seq = NULL;
	transport_generic_free_cmd(&cmd->se_cmd, 0);		transport_generic_free_cmd(&cmd->se_cmd, 0);
	return;		return;

include/target/target_core_base.h

+0 −1

Original line number	Original line	Diff line number	Diff line
	@@ -95,7 +95,6 @@ enum transport_state_table {
	TRANSPORT_ISTATE_PROCESSING = 11,		TRANSPORT_ISTATE_PROCESSING = 11,
	TRANSPORT_ISTATE_PROCESSED = 12,		TRANSPORT_ISTATE_PROCESSED = 12,
	TRANSPORT_KILL = 13,		TRANSPORT_KILL = 13,
	TRANSPORT_REMOVE = 14,
	TRANSPORT_FREE = 15,		TRANSPORT_FREE = 15,
	TRANSPORT_NEW_CMD_MAP = 16,		TRANSPORT_NEW_CMD_MAP = 16,
	TRANSPORT_FREE_CMD_INTR = 17,		TRANSPORT_FREE_CMD_INTR = 17,