Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bf5e84f6 authored by Dan Carpenter's avatar Dan Carpenter Committed by James Bottomley
Browse files

[SCSI] libosd: fix potential ERR_PTR dereference in osd_initiator.c 

bio_map_kern() returns an ERR_PTR() not NULL.

Found by smatch (http://repo.or.cz/w/smatch.git

).  Compile tested.

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarBoaz Harrosh <bharrosh@panasas.com>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
parent 3b8b5c9b

drivers/scsi/osd/osd_initiator.c

+2 −2
Original line number Diff line number Diff line
@@ -612,9 +612,9 @@ static int _osd_req_list_objects(struct osd_request *or, 


	WARN_ON(or->in.bio);

	bio = bio_map_kern(q, list, len, or->alloc_flags);

	if (!bio) {

	if (IS_ERR(bio)) {

		OSD_ERR("!!! Failed to allocate list_objects BIO\n");

		return -ENOMEM;

		return PTR_ERR(bio);

	}



	bio->bi_rw &= ~(1 << BIO_RW);