Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bdef3b02 authored by Frederic Weisbecker's avatar Frederic Weisbecker
Browse files

perf: Always record tracepoints raw samples from perf record 



Trace events are mostly used for tracing rather than simple
counting. Don't bother anymore with adding -R when using them,
just record raw samples of trace events every time.

Signed-off-by: default avatarFrederic Weisbecker <fweisbec@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>
parent 7865e817

tools/perf/Documentation/perf-record.txt

+1 −1
Original line number Diff line number Diff line
@@ -101,7 +101,7 @@ OPTIONS 


-R::

--raw-samples::

Collect raw sample records from all opened counters (typically for tracepoint counters).

Collect raw sample records from all opened counters (default for tracepoint counters).



SEE ALSO

--------

tools/perf/util/parse-events.c

+4 −10
Original line number Diff line number Diff line
@@ -410,7 +410,6 @@ static enum event_result 
parse_single_tracepoint_event(char *sys_name,

			      const char *evt_name,

			      unsigned int evt_length,

			      char *flags,

			      struct perf_event_attr *attr,

			      const char **strp)

{
@@ -419,13 +418,9 @@ parse_single_tracepoint_event(char *sys_name, 
	u64 id;

	int fd;



	if (flags) {

		if (!strncmp(flags, "record", strlen(flags))) {

	attr->sample_type |= PERF_SAMPLE_RAW;

	attr->sample_type |= PERF_SAMPLE_TIME;

	attr->sample_type |= PERF_SAMPLE_CPU;

		}

	}



	snprintf(evt_path, MAXPATHLEN, "%s/%s/%s/id", debugfs_path,

		 sys_name, evt_name);
@@ -533,8 +528,7 @@ static enum event_result parse_tracepoint_event(const char **strp, 
						       flags);

	} else

		return parse_single_tracepoint_event(sys_name, evt_name,

						     evt_length, flags,

						     attr, strp);

						     evt_length, attr, strp);

}



static enum event_result