Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bdd5c28d authored by Geyslan G. Bem's avatar Geyslan G. Bem Committed by Eric Van Hensbergen
Browse files

9p: fix return value in case in v9fs_fid_xattr_set() 



In case of error in the p9_client_write, the function v9fs_fid_xattr_set
should return its negative value, what was never being done.

In case of success it only retuned 0. Now it returns the 'offset'
variable (write_count total).

Signed-off-by: default avatarGeyslan G. Bem <geyslan@gmail.com>
Signed-off-by: default avatarEric Van Hensbergen <ericvh@gmail.com>
parent 72fe18c9

fs/9p/xattr.c

+6 −4
Original line number Diff line number Diff line
@@ -138,8 +138,7 @@ int v9fs_fid_xattr_set(struct p9_fid *fid, const char *name, 
	if (retval < 0) {

		p9_debug(P9_DEBUG_VFS, "p9_client_xattrcreate failed %d\n",

			 retval);

		p9_client_clunk(fid);

		return retval;

		goto err;

	}

	msize = fid->clnt->msize;

	while (value_len) {
@@ -152,12 +151,15 @@ int v9fs_fid_xattr_set(struct p9_fid *fid, const char *name, 
		if (write_count < 0) {

			/* error in xattr write */

			retval = write_count;

			break;

			goto err;

		}

		offset += write_count;

		value_len -= write_count;

	}

	return p9_client_clunk(fid);

	retval = offset;

err:

	p9_client_clunk(fid);

	return retval;

}



ssize_t v9fs_listxattr(struct dentry *dentry, char *buffer, size_t buffer_size)