Commit bc258006 authored Dec 13, 2009 by Julia Lawall Committed by Mark Brown Dec 14, 2009

ASoC: Correct code taking the size of a pointer

sizeof(codec->reg_cache) is just the size of the pointer.  Elsewhere in the
file, codec->reg_cache is used with sizeof(wm8900_reg_defaults), so the
code is changed to do the same here.

A simplified version of the semantic patch that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression *x;
expression f;
type T;
@@

*f(...,(T)x,...)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

parent 761c9d45

sound/soc/codecs/wm8900.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -199,7 +199,7 @@ static void wm8900_reset(struct snd_soc_codec *codec)
		snd_soc_write(codec, WM8900_REG_RESET, 0);

		memcpy(codec->reg_cache, wm8900_reg_defaults,
		sizeof(codec->reg_cache));
		sizeof(wm8900_reg_defaults));
		}

		static int wm8900_hp_event(struct snd_soc_dapm_widget *w,