Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bb02aacc authored by Erling A. Jacobsen's avatar Erling A. Jacobsen Committed by Jeff Garzik
Browse files

[PATCH] winbond-840-remove-badness-in-pci_map_single 



Call pci_map_single() with the actual size of the receive
buffers, not 0 (which skb->len is initialized to by dev_alloc_skb()).

Signed-off-by: default avatarErling A. Jacobsen <linuxcub@email.dk>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
parent f905703a

drivers/net/tulip/winbond-840.c

+2 −2
Original line number Diff line number Diff line
@@ -850,7 +850,7 @@ static void init_rxtx_rings(struct net_device *dev) 
			break;

		skb->dev = dev;			/* Mark as being used by this device. */

		np->rx_addr[i] = pci_map_single(np->pci_dev,skb->data,

					skb->len,PCI_DMA_FROMDEVICE);

					np->rx_buf_sz,PCI_DMA_FROMDEVICE);



		np->rx_ring[i].buffer1 = np->rx_addr[i];

		np->rx_ring[i].status = DescOwn;
@@ -1316,7 +1316,7 @@ static int netdev_rx(struct net_device *dev) 
			skb->dev = dev;			/* Mark as being used by this device. */

			np->rx_addr[entry] = pci_map_single(np->pci_dev,

							skb->data,

							skb->len, PCI_DMA_FROMDEVICE);

							np->rx_buf_sz, PCI_DMA_FROMDEVICE);

			np->rx_ring[entry].buffer1 = np->rx_addr[entry];

		}

		wmb();