Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b9647580 authored by Jarek Poplawski's avatar Jarek Poplawski Committed by David S. Miller
Browse files

pkt_sched: Update drops stats in act_police 



Action police statistics could be misleading because drops are not
shown when expected.

With feedback from: Jamal Hadi Salim <hadi@cyberus.ca>

Reported-by: default avatarPawel Staszewski <pstaszewski@itcare.pl>
Signed-off-by: default avatarJarek Poplawski <jarkao2@gmail.com>
Acked-by: default avatarJamal Hadi Salim <hadi@cyberus.ca>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e4f1482e

net/sched/act_police.c

+4 −0
Original line number Original line Diff line number Diff line
@@ -294,6 +294,8 @@ static int tcf_act_police(struct sk_buff *skb, struct tc_action *a, 
	if (police->tcfp_ewma_rate &&

	if (police->tcfp_ewma_rate &&

	    police->tcf_rate_est.bps >= police->tcfp_ewma_rate) {

	    police->tcf_rate_est.bps >= police->tcfp_ewma_rate) {

		police->tcf_qstats.overlimits++;

		police->tcf_qstats.overlimits++;

		if (police->tcf_action == TC_ACT_SHOT)

			police->tcf_qstats.drops++;

		spin_unlock(&police->tcf_lock);

		spin_unlock(&police->tcf_lock);

		return police->tcf_action;

		return police->tcf_action;

	}

	}
@@ -327,6 +329,8 @@ static int tcf_act_police(struct sk_buff *skb, struct tc_action *a, 
	}

	}





	police->tcf_qstats.overlimits++;

	police->tcf_qstats.overlimits++;

	if (police->tcf_action == TC_ACT_SHOT)

		police->tcf_qstats.drops++;

	spin_unlock(&police->tcf_lock);

	spin_unlock(&police->tcf_lock);

	return police->tcf_action;

	return police->tcf_action;

}

}