Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b95cd7ec authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Greg Kroah-Hartman
Browse files

USB audio gadget: Un-inline generic_[gs]et_cmd 



Those functions are used only used to fill the set/get members of
usb_audio_control. It doesn't make much sense to inline them.

Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@skynet.be>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 512ad27d

drivers/usb/gadget/f_audio.c

+15 −0
Original line number Diff line number Diff line
@@ -28,6 +28,9 @@ static int audio_buf_size = 48000; 
module_param(audio_buf_size, int, S_IRUGO);

MODULE_PARM_DESC(audio_buf_size, "Audio buffer size");



static int generic_set_cmd(struct usb_audio_control *con, u8 cmd, int value);

static int generic_get_cmd(struct usb_audio_control *con, u8 cmd);



/*

 * DESCRIPTORS ... most are static, but strings and full

 * configuration descriptors are built on demand.
@@ -632,6 +635,18 @@ f_audio_unbind(struct usb_configuration *c, struct usb_function *f) 


/*-------------------------------------------------------------------------*/



static int generic_set_cmd(struct usb_audio_control *con, u8 cmd, int value)

{

	con->data[cmd] = value;



	return 0;

}



static int generic_get_cmd(struct usb_audio_control *con, u8 cmd)

{

	return con->data[cmd];

}



/* Todo: add more control selecotor dynamically */

int __init control_selector_init(struct f_audio *audio)

{

include/linux/usb/audio.h

+0 −12
Original line number Diff line number Diff line
@@ -285,18 +285,6 @@ struct usb_audio_control { 
	int (*get)(struct usb_audio_control *con, u8 cmd);

};



static inline int generic_set_cmd(struct usb_audio_control *con, u8 cmd, int value)

{

	con->data[cmd] = value;



	return 0;

}



static inline int generic_get_cmd(struct usb_audio_control *con, u8 cmd)

{

	return con->data[cmd];

}



struct usb_audio_control_selector {

	struct list_head list;

	struct list_head control;