Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b949be58 authored by George Spelvin's avatar George Spelvin Committed by Jens Axboe
Browse files

idr: document exit conditions on idr_for_each_entry better 



And some manual common subexpression elimination which may help the
compiler produce smaller code.

Signed-off-by: default avatarGeorge Spelvin <linux@horizon.com>
Signed-off-by: default avatarPhilipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 29177b89

include/linux/idr.h

+6 −4
Original line number Diff line number Diff line
@@ -122,11 +122,13 @@ static inline void *idr_find(struct idr *idr, int id) 
 * @idp:     idr handle

 * @entry:   the type * to use as cursor

 * @id:      id entry's key

 *

 * @entry and @id do not need to be initialized before the loop, and

 * after normal terminatinon @entry is left with the value NULL.  This

 * is convenient for a "not found" value.

 */

#define idr_for_each_entry(idp, entry, id)			\

	for (id = 0, entry = (typeof(entry))idr_get_next((idp), &(id)); \

	     entry != NULL;                                             \

	     ++id, entry = (typeof(entry))idr_get_next((idp), &(id)))

	for (id = 0; ((entry) = idr_get_next(idp, &(id))) != NULL; ++id)



/*

 * Don't use the following functions.  These exist only to suppress