Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b8f4e068 authored by Gustavo Padovan's avatar Gustavo Padovan
Browse files

Bluetooth: Improve comments on the HCI_Delete_Store_Link_Key issue 



Some Bluetooth controllers doesn't support this command so we first
need to check for its support before sending it. This patch adds a
lengthful commentary about this.

Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
Signed-off-by: default avatarGustavo Padovan <gustavo.padovan@collabora.co.uk>
parent 502f7696

net/bluetooth/hci_core.c

+9 −1
Original line number Diff line number Diff line
@@ -597,7 +597,15 @@ static void hci_init3_req(struct hci_request *req, unsigned long opt) 
	struct hci_dev *hdev = req->hdev;

	u8 p;



	/* Only send HCI_Delete_Stored_Link_Key if it is supported */

	/* Some Broadcom based Bluetooth controllers do not support the

	 * Delete Stored Link Key command. They are clearly indicating its

	 * absence in the bit mask of supported commands.

	 *

	 * Check the supported commands and only if the the command is marked

	 * as supported send it. If not supported assume that the controller

	 * does not have actual support for stored link keys which makes this

	 * command redundant anyway.

         */

	if (hdev->commands[6] & 0x80) {

		struct hci_cp_delete_stored_link_key cp;