Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b8c19eb1 authored by Grant Likely's avatar Grant Likely Committed by Paul Mackerras
Browse files

[POWERPC] mpc5200-fec: Fix possible NULL dereference in mdio driver 



If the reg property is missing from the phy node (unlikely, but possible),
then the kernel will oops with a NULL pointer dereference.  This fixes
it by checking the pointer first.

Signed-off-by: default avatarGrant Likely <grant.likely@secretlab.ca>
Signed-off-by: default avatarPaul Mackerras <paulus@samba.org>
parent 1428a9fa

drivers/net/fec_mpc52xx_phy.c

+2 −1
Original line number Diff line number Diff line
@@ -109,6 +109,7 @@ static int mpc52xx_fec_mdio_probe(struct of_device *of, const struct of_device_i 
		int irq = irq_of_parse_and_map(child, 0);

		if (irq != NO_IRQ) {

			const u32 *id = of_get_property(child, "reg", NULL);

			if (id)

				bus->irq[*id] = irq;

		}

	}