Commit b8a64959 authored May 04, 2018 by Silvio Cesare Committed by Greg Kroah-Hartman Jul 03, 2018

UBIFS: Fix potential integer overflow in allocation



commit 353748a359f1821ee934afc579cf04572406b420 upstream.

There is potential for the size and len fields in ubifs_data_node to be
too large causing either a negative value for the length fields or an
integer overflow leading to an incorrect memory allocation. Likewise,
when the len field is small, an integer underflow may occur.

Signed-off-by: Silvio Cesare <silvio.cesare@gmail.com>
Fixes: 1e51764a ("UBIFS: add new flash file system")
Cc: stable@vger.kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 5f14b032

fs/ubifs/journal.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1101,7 +1101,7 @@ static int recomp_data_node(struct ubifs_data_node dn, int new_len)
		int err, len, compr_type, out_len;

		out_len = le32_to_cpu(dn->size);
		buf = kmalloc(out_len * WORST_COMPR_FACTOR, GFP_NOFS);
		buf = kmalloc_array(out_len, WORST_COMPR_FACTOR, GFP_NOFS);
		if (!buf)
		return -ENOMEM;