Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b8a0b0d1 authored by Rashika's avatar Rashika Committed by Rafael J. Wysocki
Browse files

ACPI / EC: Remove unused functions and add prototype declaration in internal.h 



Adds the prototype declarations of functions acpi_ec_add_query_handler()
and acpi_ec_remove_query_handler() in header file internal.h and removes
unused functions ec_burst_enable() and ec_burst_disable() in ec.c.

This eliminates the following warnings in ec.c:
drivers/acpi/ec.c:393:5: warning: no previous prototype for ‘ec_burst_enable’ [-Wmissing-prototypes]
drivers/acpi/ec.c:402:5: warning: no previous prototype for ‘ec_burst_disable’ [-Wmissing-prototypes]
drivers/acpi/ec.c:531:5: warning: no previous prototype for ‘acpi_ec_add_query_handler’ [-Wmissing-prototypes]
drivers/acpi/ec.c:552:6: warning: no previous prototype for ‘acpi_ec_remove_query_handler’ [-Wmissing-prototypes]

Signed-off-by: default avatarRashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: default avatarJosh Triplett <josh@joshtriplett.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 3f9eed5c

drivers/acpi/ec.c

+0 −25
Original line number Diff line number Diff line
@@ -90,10 +90,6 @@ static unsigned int ec_storm_threshold __read_mostly = 8; 
module_param(ec_storm_threshold, uint, 0644);

MODULE_PARM_DESC(ec_storm_threshold, "Maxim false GPE numbers not considered as GPE storm");



/* If we find an EC via the ECDT, we need to keep a ptr to its context */

/* External interfaces use first EC only, so remember */

typedef int (*acpi_ec_query_func) (void *data);



struct acpi_ec_query_handler {

	struct list_head node;

	acpi_ec_query_func func;
@@ -386,27 +382,6 @@ static int acpi_ec_write(struct acpi_ec *ec, u8 address, u8 data) 
	return acpi_ec_transaction(ec, &t);

}



/*

 * Externally callable EC access functions. For now, assume 1 EC only

 */

int ec_burst_enable(void)

{

	if (!first_ec)

		return -ENODEV;

	return acpi_ec_burst_enable(first_ec);

}



EXPORT_SYMBOL(ec_burst_enable);



int ec_burst_disable(void)

{

	if (!first_ec)

		return -ENODEV;

	return acpi_ec_burst_disable(first_ec);

}



EXPORT_SYMBOL(ec_burst_disable);



int ec_read(u8 addr, u8 *val)

{

	int err;

drivers/acpi/internal.h

+9 −0
Original line number Diff line number Diff line
@@ -127,12 +127,21 @@ struct acpi_ec { 


extern struct acpi_ec *first_ec;



/* If we find an EC via the ECDT, we need to keep a ptr to its context */

/* External interfaces use first EC only, so remember */

typedef int (*acpi_ec_query_func) (void *data);



int acpi_ec_init(void);

int acpi_ec_ecdt_probe(void);

int acpi_boot_ec_enable(void);

void acpi_ec_block_transactions(void);

void acpi_ec_unblock_transactions(void);

void acpi_ec_unblock_transactions_early(void);

int acpi_ec_add_query_handler(struct acpi_ec *ec, u8 query_bit,

			      acpi_handle handle, acpi_ec_query_func func,

			      void *data);

void acpi_ec_remove_query_handler(struct acpi_ec *ec, u8 query_bit);





/*--------------------------------------------------------------------------

                                  Suspend/Resume