Commit b88fb18e authored Dec 10, 2012 by Florian Fainelli Committed by Ralf Baechle Dec 13, 2012

MIPS: MT: Fix build with CONFIG_UIDGID_STRICT_TYPE_CHECKS=y



When CONFIG_UIDGID_STRICT_TYPE_CHECKS is enabled, plain integer checking
between different uids/gids is explicitely turned into a build failure
by making the k{uid,gid}_t types a structure containing a value:

arch/mips/kernel/mips-mt-fpaff.c: In function 'check_same_owner':
arch/mips/kernel/mips-mt-fpaff.c:53:22: error: invalid operands to
binary == (have 'kuid_t' and 'kuid_t')
arch/mips/kernel/mips-mt-fpaff.c:54:15: error: invalid operands to
binary == (have 'kuid_t' and 'kuid_t')

In order to ensure proper comparison between uids, using the helper
function uid_eq() which performs the right thing whenever this config
option is turned on or off.

Signed-off-by: Florian Fainelli <florian@openwrt.org>
Patchwork: https://patchwork.linux-mips.org/patch/4717/


Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

parent a685bc3d

arch/mips/kernel/mips-mt-fpaff.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -50,8 +50,8 @@ static bool check_same_owner(struct task_struct *p)

		rcu_read_lock();
		pcred = __task_cred(p);
		match = (cred->euid == pcred->euid \|\|
		cred->euid == pcred->uid);
		match = (uid_eq(cred->euid, pcred->euid) \|\|
		uid_eq(cred->euid, pcred->uid));
		rcu_read_unlock();
		return match;
		}