Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b803cc58 authored by Jesper Juhl's avatar Jesper Juhl Committed by Mauro Carvalho Chehab
Browse files

[media] staging: as102: Remove redundant NULL check before release_firmware()... 


[media] staging: as102: Remove redundant NULL check before release_firmware() and pointless comments

release_firmware() deals gracefullt with NULL pointers - it's
redundant to check for them before calling the function.

Also remove a few pointless comments - it's rather obvious from the
code that kfree() free's a buffer and that release_firmware() releases
firmware - comments just stating that add no value.

Signed-off-by: default avatarJesper Juhl <jj@chaosbits.net>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 0a3475eb

drivers/staging/media/as102/as102_fw.c

+1 −4
Original line number Diff line number Diff line
@@ -230,10 +230,7 @@ int as102_fw_upload(struct as10x_bus_adapter_t *bus_adap) 
	pr_info("%s: firmware: %s loaded with success\n",

		DRIVER_NAME, fw2);

error:

	/* free data buffer */

	kfree(cmd_buf);

	/* release firmware if needed */

	if (firmware != NULL)

	release_firmware(firmware);



	LEAVE();