Commit b8031342 authored Oct 16, 2012 by Sarah Sharp

xhci: Fix missing break in xhci_evaluate_context_result.



Coverity complains that xhci_evaluate_context_result() is missing a
break statement after the COMP_EBADSLT switch case.  It's not a big
deal, since we wanted to return the same error code as the case
statement below it does.  The end result would be one that a Slot
Disabled error completion code would also print the warning message
associated with a Context State error code.  No other bad behavior would
result.

It's not worth backporting to stable kernels, since it only fixes an
issue with too much debugging.

Signed-off-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>

parent 43a09f7f

drivers/usb/host/xhci.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1817,6 +1817,8 @@ static int xhci_evaluate_context_result(struct xhci_hcd *xhci,
		case COMP_EBADSLT:
		dev_warn(&udev->dev, "WARN: slot not enabled for"
		"evaluate context command.\n");
		ret = -EINVAL;
		break;
		case COMP_CTX_STATE:
		dev_warn(&udev->dev, "WARN: invalid context state for "
		"evaluate context command.\n");