Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b7ff160a authored by Theodore Ts'o's avatar Theodore Ts'o Committed by Greg Kroah-Hartman
Browse files

ext4: fix fencepost in s_first_meta_bg validation 

commit 2ba3e6e8afc9b6188b471f27cf2b5e3cf34e7af2 upstream.

It is OK for s_first_meta_bg to be equal to the number of block group
descriptor blocks.  (It rarely happens, but it shouldn't cause any
problems.)

https://bugzilla.kernel.org/show_bug.cgi?id=194567



Fixes: 3a4b77cd47bb837b8557595ec7425f281f2ca1fe
Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
Cc: Eryu Guan <guaneryu@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2ce649fd

fs/ext4/super.c

+1 −1
Original line number Diff line number Diff line
@@ -3932,7 +3932,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) 
	db_count = (sbi->s_groups_count + EXT4_DESC_PER_BLOCK(sb) - 1) /

		   EXT4_DESC_PER_BLOCK(sb);

	if (EXT4_HAS_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_META_BG)) {

		if (le32_to_cpu(es->s_first_meta_bg) >= db_count) {

		if (le32_to_cpu(es->s_first_meta_bg) > db_count) {

			ext4_msg(sb, KERN_WARNING,

				 "first meta block group too large: %u "

				 "(group descriptor block count %u)",