Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b6ff24a3 authored by Sage Weil's avatar Sage Weil Committed by Al Viro
Browse files

cifs: remove unnecessary dentry_unhash on rmdir/rename_dir



Cifs has no problems with lingering references to unlinked directory
inodes.

CC: Steve French <sfrench@samba.org>
CC: linux-cifs@vger.kernel.org
Signed-off-by: default avatarSage Weil <sage@newdream.net>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 7ca57363
Loading
Loading
Loading
Loading
+0 −5
Original line number Diff line number Diff line
@@ -1461,8 +1461,6 @@ int cifs_rmdir(struct inode *inode, struct dentry *direntry)

	cFYI(1, "cifs_rmdir, inode = 0x%p", inode);

	dentry_unhash(direntry);

	xid = GetXid();

	full_path = build_path_from_dentry(direntry);
@@ -1571,9 +1569,6 @@ int cifs_rename(struct inode *source_dir, struct dentry *source_dentry,
	FILE_UNIX_BASIC_INFO *info_buf_target;
	int xid, rc, tmprc;

	if (target_dentry->d_inode && S_ISDIR(target_dentry->d_inode->i_mode))
		dentry_unhash(target_dentry);

	cifs_sb = CIFS_SB(source_dir->i_sb);
	tlink = cifs_sb_tlink(cifs_sb);
	if (IS_ERR(tlink))