Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b64d39d8 authored by Maxim Levitsky's avatar Maxim Levitsky Committed by David Woodhouse
Browse files

mtd: nand: make reads using MTD_OOB_RAW affect only ECC validation 



This changes the behavier of MTD_OOB_RAW. It used to read both OOB and 
data to the data buffer, however you would still need to specify the 
dummy oob buffer.

This is only used in one place, but makes it hard to read data+oob 
without ECC test, thus I removed that behavier, and fixed the user.

Now MTD_OOB_RAW behaves just like MTD_OOB_PLACE, but doesn't do ECC 
validation

Signed-off-by: default avatarMaxim Levitsky <maximlevitsky@gmail.com>
Signed-off-by: default avatarDavid Woodhouse <David.Woodhouse@intel.com>
parent 782ce79a

drivers/mtd/nand/nand_base.c

+7 −12
Original line number Diff line number Diff line
@@ -1474,18 +1474,13 @@ static int nand_do_read_ops(struct mtd_info *mtd, loff_t from, 


			if (unlikely(oob)) {



				/* Raw mode does data:oob:data:oob */

				if (ops->mode != MTD_OOB_RAW) {

					int toread = min(oobreadlen,

								max_oobsize);

				int toread = min(oobreadlen, max_oobsize);



				if (toread) {

					oob = nand_transfer_oob(chip,

						oob, ops, toread);

					oobreadlen -= toread;

				}

				} else

					buf = nand_transfer_oob(chip,

						buf, ops, mtd->oobsize);

			}



			if (!(chip->options & NAND_NO_READRDY)) {

drivers/mtd/nand/nand_bbt.c

+22 −4
Original line number Diff line number Diff line
@@ -237,15 +237,33 @@ static int scan_read_raw(struct mtd_info *mtd, uint8_t *buf, loff_t offs, 
			 size_t len)

{

	struct mtd_oob_ops ops;

	int res;



	ops.mode = MTD_OOB_RAW;

	ops.ooboffs = 0;

	ops.ooblen = mtd->oobsize;

	ops.oobbuf = buf;





	while (len > 0) {

		if (len <= mtd->writesize) {

			ops.oobbuf = buf + len;

			ops.datbuf = buf;

			ops.len = len;



			return mtd->read_oob(mtd, offs, &ops);

		} else {

			ops.oobbuf = buf + mtd->writesize;

			ops.datbuf = buf;

			ops.len = mtd->writesize;

			res = mtd->read_oob(mtd, offs, &ops);



			if (res)

				return res;

		}



		buf += mtd->oobsize + mtd->writesize;

		len -= mtd->writesize;

	}

	return 0;

}



/*

include/linux/mtd/mtd.h

+1 −3
Original line number Diff line number Diff line
@@ -60,9 +60,7 @@ struct mtd_erase_region_info { 
 * MTD_OOB_PLACE:	oob data are placed at the given offset

 * MTD_OOB_AUTO:	oob data are automatically placed at the free areas

 *			which are defined by the ecclayout

 * MTD_OOB_RAW:		mode to read raw data+oob in one chunk. The oob data

 *			is inserted into the data. Thats a raw image of the

 *			flash contents.

 * MTD_OOB_RAW:		mode to read oob and data without doing ECC checking

 */

typedef enum {

	MTD_OOB_PLACE,