Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b5daa70a authored by Krzysztof Helt's avatar Krzysztof Helt Committed by Linus Torvalds
Browse files

fsl-diu-fb: fix regression with uninitalized fb_info->mm_lock mutex 



Remove call to the fsl_diu_set_par before the register_framebuffer().

This fixes a problem with uninitialized the fb_info->mm_lock mutex
introduced by the commit 537a1bf0 " fbdev: add mutex for fb_mmap
locking"

Signed-off-by: default avatarKrzysztof Helt <krzysztof.h1@wp.pl>
Tested-by: default avatar"Kai Jiang" <b18973@freescale.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 44b57280

drivers/video/fsl-diu-fb.c

+0 −6
Original line number Diff line number Diff line
@@ -1223,12 +1223,6 @@ static int __devinit install_fb(struct fb_info *info) 
		return -EINVAL;

	}



	if (fsl_diu_set_par(info)) {

		printk(KERN_ERR "fb_set_par failed");

		fb_dealloc_cmap(&info->cmap);

		return -EINVAL;

	}



	if (register_framebuffer(info) < 0) {

		printk(KERN_ERR "register_framebuffer failed");

		unmap_video_memory(info);