Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b5975917 authored by Thomas Gleixner's avatar Thomas Gleixner Committed by Tony Luck
Browse files

x86: mce: Serialize mce injection 



raise_mce() fiddles with global state, but lacks any kind of
serialization.

Add a mutex around the raise_mce() call, so concurrent writers do not
stomp on each other toes.

Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Signed-off-by: default avatarChen Gong <gong.chen@linux.intel.com>
Signed-off-by: default avatarTony Luck <tony.luck@intel.com>
parent ea22571c

arch/x86/kernel/cpu/mcheck/mce-inject.c

+4 −0
Original line number Diff line number Diff line
@@ -78,6 +78,7 @@ static void raise_exception(struct mce *m, struct pt_regs *pregs) 
}



static cpumask_var_t mce_inject_cpumask;

static DEFINE_MUTEX(mce_inject_mutex);



static int mce_raise_notify(unsigned int cmd, struct pt_regs *regs)

{
@@ -229,7 +230,10 @@ static ssize_t mce_write(struct file *filp, const char __user *ubuf, 
	 * so do it a jiffie or two later everywhere.

	 */

	schedule_timeout(2);



	mutex_lock(&mce_inject_mutex);

	raise_mce(&m);

	mutex_unlock(&mce_inject_mutex);

	return usize;

}