Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b558ba2f authored by Emilio G. Cota's avatar Emilio G. Cota Committed by Greg Kroah-Hartman
Browse files

staging: vme: tsi148: use list_for_each_safe when deleting resources in .remove 



This fixes an oops when removing the module.

Signed-off-by: default avatarEmilio G. Cota <cota@braap.org>
Acked-by: default avatarMartyn Welch <martyn.welch@ge.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent db6d8fc5

drivers/staging/vme/bridges/vme_tsi148.c

+4 −3
Original line number Diff line number Diff line
@@ -2531,6 +2531,7 @@ err_struct: 
static void tsi148_remove(struct pci_dev *pdev)

{

	struct list_head *pos = NULL;

	struct list_head *tmplist;

	struct vme_master_resource *master_image;

	struct vme_slave_resource *slave_image;

	struct vme_dma_resource *dma_ctrlr;
@@ -2589,21 +2590,21 @@ static void tsi148_remove(struct pci_dev *pdev) 
	tsi148_crcsr_exit(tsi148_bridge, pdev);



	/* resources are stored in link list */

	list_for_each(pos, &tsi148_bridge->dma_resources) {

	list_for_each_safe(pos, tmplist, &tsi148_bridge->dma_resources) {

		dma_ctrlr = list_entry(pos, struct vme_dma_resource, list);

		list_del(pos);

		kfree(dma_ctrlr);

	}



	/* resources are stored in link list */

	list_for_each(pos, &tsi148_bridge->slave_resources) {

	list_for_each_safe(pos, tmplist, &tsi148_bridge->slave_resources) {

		slave_image = list_entry(pos, struct vme_slave_resource, list);

		list_del(pos);

		kfree(slave_image);

	}



	/* resources are stored in link list */

	list_for_each(pos, &tsi148_bridge->master_resources) {

	list_for_each_safe(pos, tmplist, &tsi148_bridge->master_resources) {

		master_image = list_entry(pos, struct vme_master_resource,

			list);

		list_del(pos);