Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b54cb233 authored by Peter Zijlstra's avatar Peter Zijlstra Committed by Helge Deller
Browse files

parisc: remove IRQF_DISABLED 



People are playing odd games with IRQF_DISABLED, remove it.

Its not reliable, since shared interrupt lines could disable it for you,
and its possible and allowed for archs to disable IRQs to limit IRQ nesting.

Therefore, simply mandate that _ALL_ IRQ handlers are run with IRQs disabled.

[ This _should_ not break anything, since we've mandated that IRQ handlers
  _must_ be able to deal with this for a _long_ time ]

IRQ handlers should be fast, no if buts and any other exceptions. We also have
plenty instrumentation to find any offending IRQ latency sources.

Signed-off-by: default avatarPeter Zijlstra <a.p.zijlstra@chello.nl>
Acked-by: default avatarIngo Molnar <mingo@elte.hu>
Signed-off-by: default avatarHelge Deller <deller@gmx.de>
parent cca8e902

arch/parisc/include/asm/floppy.h

+2 −2
Original line number Diff line number Diff line
@@ -157,10 +157,10 @@ static int fd_request_irq(void) 
{

	if(can_use_virtual_dma)

		return request_irq(FLOPPY_IRQ, floppy_hardint,

				   IRQF_DISABLED, "floppy", NULL);

				   0, "floppy", NULL);

	else

		return request_irq(FLOPPY_IRQ, floppy_interrupt,

				   IRQF_DISABLED, "floppy", NULL);

				   0, "floppy", NULL);

}



static unsigned long dma_mem_alloc(unsigned long size)

arch/parisc/kernel/irq.c

+2 −2
Original line number Diff line number Diff line
@@ -379,14 +379,14 @@ void do_cpu_irq_mask(struct pt_regs *regs) 
static struct irqaction timer_action = {

	.handler = timer_interrupt,

	.name = "timer",

	.flags = IRQF_DISABLED | IRQF_TIMER | IRQF_PERCPU | IRQF_IRQPOLL,

	.flags = IRQF_TIMER | IRQF_PERCPU | IRQF_IRQPOLL,

};



#ifdef CONFIG_SMP

static struct irqaction ipi_action = {

	.handler = ipi_interrupt,

	.name = "IPI",

	.flags = IRQF_DISABLED | IRQF_PERCPU,

	.flags = IRQF_PERCPU,

};

#endif

drivers/parisc/superio.c

+1 −1
Original line number Diff line number Diff line
@@ -274,7 +274,7 @@ superio_init(struct pci_dev *pcidev) 
	else

		printk(KERN_ERR PFX "USB regulator not initialized!\n");



	if (request_irq(pdev->irq, superio_interrupt, IRQF_DISABLED,

	if (request_irq(pdev->irq, superio_interrupt, 0,

			SUPERIO, (void *)sio)) {



		printk(KERN_ERR PFX "could not get irq\n");