Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b4b09fed authored by Subhash Jadavani's avatar Subhash Jadavani
Browse files

scsi: ufs: enable FASTAUTO mode during low load condition 



We are currently running UFS link in HS-G3 FAST mode during high load
condition for best possible performance and in HS-G2 FAST mode during
low load condition to save power. As we are anyway scaling down from
HS-G3 to HS-G2, we can also change the mode from FAST to FASTAUTO.
So we looked at the performance numbers with HS-G2 FASTAUTO mode and
they are good enough for most of the low bandwidth usecases. But Samsung
UFS memory devices are exception which has really low sequential read
throughput in FAST AUTO mode hence we will only be enabling FAST AUTO mode
for other UFS device vendors.

Change-Id: Ia79da3e82fb87c0e396534979398617388f40af9
Signed-off-by: default avatarSubhash Jadavani <subhashj@codeaurora.org>
parent d3846f3c

drivers/scsi/ufs/ufs_quirks.c

+2 −0
Original line number Diff line number Diff line
@@ -20,6 +20,8 @@ static struct ufs_card_fix ufs_fixups[] = { 
	UFS_FIX(UFS_VENDOR_SAMSUNG, UFS_ANY_MODEL, UFS_DEVICE_NO_VCCQ),

	UFS_FIX(UFS_VENDOR_SAMSUNG, UFS_ANY_MODEL,

		UFS_DEVICE_QUIRK_RECOVERY_FROM_DL_NAC_ERRORS),

	UFS_FIX(UFS_VENDOR_SAMSUNG, UFS_ANY_MODEL,

		UFS_DEVICE_NO_FASTAUTO),

	UFS_FIX(UFS_VENDOR_TOSHIBA, "THGLF2G9C8KBADG",

		UFS_DEVICE_QUIRK_PA_TACTIVATE),

	UFS_FIX(UFS_VENDOR_TOSHIBA, "THGLF2G9D8KBADG",

drivers/scsi/ufs/ufs_quirks.h

+7 −0
Original line number Diff line number Diff line
@@ -115,6 +115,13 @@ struct ufs_card_fix { 
 */

#define UFS_DEVICE_QUIRK_PA_TACTIVATE	(1 << 4)



/*

 * Some UFS memory devices may have really low read/write throughput in

 * FAST AUTO mode, enable this quirk to make sure that FAST AUTO mode is

 * never enabled for such devices.

 */

#define UFS_DEVICE_NO_FASTAUTO		(1 << 5)



struct ufs_hba;

void ufs_advertise_fixup_device(struct ufs_hba *hba);

#endif /* UFS_QUIRKS_H_ */

drivers/scsi/ufs/ufshcd.c

+4 −0
Original line number Diff line number Diff line
@@ -8456,6 +8456,10 @@ static int ufshcd_scale_gear(struct ufs_hba *hba, bool scale_up) 
			/* scale down gear */

			new_pwr_info.gear_tx = UFS_MIN_GEAR_TO_SCALE_DOWN;

			new_pwr_info.gear_rx = UFS_MIN_GEAR_TO_SCALE_DOWN;

			if (!(hba->dev_quirks & UFS_DEVICE_NO_FASTAUTO)) {

				new_pwr_info.pwr_tx = FASTAUTO_MODE;

				new_pwr_info.pwr_rx = FASTAUTO_MODE;

			}

		}

	}