Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b40272e4 authored by Benjamin Tissoires's avatar Benjamin Tissoires Committed by Jiri Kosina
Browse files

HID: remove hidinput_input_event handler 



All the different transport drivers use now the generic event handling
in hid-input. We can remove the handler definitively now.

Reviewed-by: default avatarDavid Herrmann <dh.herrmann@gmail.com>
Signed-off-by: default avatarBenjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 2f0cd030

drivers/hid/hid-input.c

+1 −3
Original line number Diff line number Diff line
@@ -1263,9 +1263,7 @@ static struct hid_input *hidinput_allocate(struct hid_device *hid) 
	}



	input_set_drvdata(input_dev, hid);

	if (hid->ll_driver->hidinput_input_event)

		input_dev->event = hid->ll_driver->hidinput_input_event;

	else if (hid->ll_driver->request || hid->hid_output_raw_report)

	if (hid->ll_driver->request || hid->hid_output_raw_report)

		input_dev->event = hidinput_input_event;

	input_dev->open = hidinput_open;

	input_dev->close = hidinput_close;

include/linux/hid.h

+0 −4
Original line number Diff line number Diff line
@@ -675,7 +675,6 @@ struct hid_driver { 
 * @stop: called on remove

 * @open: called by input layer on open

 * @close: called by input layer on close

 * @hidinput_input_event: event input event (e.g. ff or leds)

 * @parse: this method is called only once to parse the device data,

 *	   shouldn't allocate anything to not leak memory

 * @request: send report request to device (e.g. feature report)
@@ -693,9 +692,6 @@ struct hid_ll_driver { 


	int (*power)(struct hid_device *hdev, int level);



	int (*hidinput_input_event) (struct input_dev *idev, unsigned int type,

			unsigned int code, int value);



	int (*parse)(struct hid_device *hdev);



	void (*request)(struct hid_device *hdev,