Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b3d18f15 authored by Julia Lawall's avatar Julia Lawall Committed by David S. Miller
Browse files

net/ax25: Use available error codes 

Error codes are stored in err, but the return value is always 0.  Return
err instead.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@r@
local idexpression x;
constant C;
@@

if (...) { ...
  x = -C
  ... when != x
(
  return <+...x...+>;
|
  return NULL;
|
  return;
|
* return ...;
)
}
// </smpl>

Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Acked-by: default avatarRalf Baechle <ralf@linux-mips.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 636b8116

net/ax25/ax25_route.c

+2 −2
Original line number Diff line number Diff line
@@ -412,7 +412,7 @@ int ax25_rt_autobind(ax25_cb *ax25, ax25_address *addr) 
{

	ax25_uid_assoc *user;

	ax25_route *ax25_rt;

	int err;

	int err = 0;



	if ((ax25_rt = ax25_get_route(addr, NULL)) == NULL)

		return -EHOSTUNREACH;
@@ -453,7 +453,7 @@ int ax25_rt_autobind(ax25_cb *ax25, ax25_address *addr) 
put:

	ax25_put_route(ax25_rt);



	return 0;

	return err;

}



struct sk_buff *ax25_rt_build_path(struct sk_buff *skb, ax25_address *src,