Commit b39599b7 authored Mar 06, 2013 by Suman Anna Committed by Ohad Ben-Cohen Apr 05, 2013

remoteproc: fix the error check for idr_alloc



The new idr_alloc interface returns the allocated id back
on success, so fix the error path to check for negative
values. This was missed out in the newer idr interface
adoption patch, 15fc6110 "remoteproc: convert to idr_alloc()".

Signed-off-by: Suman Anna <s-anna@ti.com>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>

parent f6161aa1

drivers/remoteproc/remoteproc_core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -217,7 +217,7 @@ int rproc_alloc_vring(struct rproc_vdev *rvdev, int i)
		* TODO: support predefined notifyids (via resource table)
		*/
		ret = idr_alloc(&rproc->notifyids, rvring, 0, 0, GFP_KERNEL);
		if (ret) {
		if (ret < 0) {
		dev_err(dev, "idr_alloc failed: %d\n", ret);
		dma_free_coherent(dev->parent, size, va, dma);
		return ret;