Commit b38f87ec authored Nov 15, 2013 by Wei Yongjun Committed by Mark Brown Nov 15, 2013

spi: txx9: fix reference leak to master in txx9spi_remove()



Once a spi_master_get() call succeeds, we need an additional
spi_master_put() call to free the memory, otherwise we will
leak a reference to master. Fix by removing the unnecessary
spi_master_get() call.

Fixes: 2fe7e4ad ('spi: txx9: use devm_spi_register_master()')
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Mark Brown <broonie@linaro.org>

parent 82f85cf9

drivers/spi/spi-txx9.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -425,7 +425,7 @@ exit:

		static int txx9spi_remove(struct platform_device *dev)
		{
		struct spi_master *master = spi_master_get(platform_get_drvdata(dev));
		struct spi_master *master = platform_get_drvdata(dev);
		struct txx9spi *c = spi_master_get_devdata(master);

		destroy_workqueue(c->workqueue);