Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b2b0154e authored by Stefan Weinhuber's avatar Stefan Weinhuber Committed by Martin Schwidefsky
Browse files

s390/dasd: fix memory leak caused by dangling references to request_queue 



After the call to del_gendisk, the gendisk still holds a reference to
its request_queue. We must not modify the gendisks queue pointer
before the put_disk call, or the gendisk_release function cannot
release the reference and the memory for the request_queue structure
is lost.

Signed-off-by: default avatarStefan Weinhuber <wein@de.ibm.com>
Signed-off-by: default avatarMartin Schwidefsky <schwidefsky@de.ibm.com>
parent af91706d

drivers/s390/block/dasd_genhd.c

+0 −1
Original line number Diff line number Diff line
@@ -87,7 +87,6 @@ void dasd_gendisk_free(struct dasd_block *block) 
{

	if (block->gdp) {

		del_gendisk(block->gdp);

		block->gdp->queue = NULL;

		block->gdp->private_data = NULL;

		put_disk(block->gdp);

		block->gdp = NULL;