Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b21a9104 authored by roel kluin's avatar roel kluin Committed by Paul Mundt
Browse files

sh: intc_prio_data() test before subtraction on unsigned 



bit is unsigned, so test before subtraction

Signed-off-by: default avatarRoel Kluin <roel.kluin@gmail.com>
Signed-off-by: default avatarPaul Mundt <lethal@linux-sh.org>
parent 6eb2139b

arch/sh/kernel/cpu/irq/intc.c

+6 −4
Original line number Diff line number Diff line
@@ -464,9 +464,10 @@ static unsigned int __init intc_prio_data(struct intc_desc *desc, 
			}



			fn += (pr->reg_width >> 3) - 1;

			bit = pr->reg_width - ((j + 1) * pr->field_width);



			BUG_ON(bit < 0);

			BUG_ON((j + 1) * pr->field_width > pr->reg_width);



			bit = pr->reg_width - ((j + 1) * pr->field_width);



			return _INTC_MK(fn, mode,

					intc_get_reg(d, reg_e),
@@ -531,9 +532,10 @@ static unsigned int __init intc_sense_data(struct intc_desc *desc, 


			fn = REG_FN_MODIFY_BASE;

			fn += (sr->reg_width >> 3) - 1;

			bit = sr->reg_width - ((j + 1) * sr->field_width);



			BUG_ON(bit < 0);

			BUG_ON((j + 1) * sr->field_width > sr->reg_width);



			bit = sr->reg_width - ((j + 1) * sr->field_width);



			return _INTC_MK(fn, 0, intc_get_reg(d, sr->reg),

					0, sr->field_width, bit);