Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b1ffdc8f authored by Dan Carpenter's avatar Dan Carpenter Committed by Jiri Kosina
Browse files

i2o: cleanup some exit paths 



This is just a cleanup and doesn't change how the code works.

The original code had a mix of returns and gotos so I changed everything
to just return directly.

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Reviewed-by: default avatarChristoph Lameter <cl@linux-foundation.org>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent a33f3224

drivers/message/i2o/i2o_config.c

+6 −10
Original line number Diff line number Diff line
@@ -314,22 +314,22 @@ static int i2o_cfg_swul(unsigned long arg) 
	int ret = 0;



	if (copy_from_user(&kxfer, pxfer, sizeof(struct i2o_sw_xfer)))

		goto return_fault;

		return -EFAULT;



	if (get_user(swlen, kxfer.swlen) < 0)

		goto return_fault;

		return -EFAULT;



	if (get_user(maxfrag, kxfer.maxfrag) < 0)

		goto return_fault;

		return -EFAULT;



	if (get_user(curfrag, kxfer.curfrag) < 0)

		goto return_fault;

		return -EFAULT;



	if (curfrag == maxfrag)

		fragsize = swlen - (maxfrag - 1) * 8192;



	if (!kxfer.buf)

		goto return_fault;

		return -EFAULT;



	c = i2o_find_iop(kxfer.iop);

	if (!c)
@@ -373,12 +373,8 @@ static int i2o_cfg_swul(unsigned long arg) 


	i2o_dma_free(&c->pdev->dev, &buffer);



      return_ret:

	return ret;

      return_fault:

	ret = -EFAULT;

	goto return_ret;

};

}



static int i2o_cfg_swdel(unsigned long arg)

{