Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b1e056ae authored by Venkatraman S's avatar Venkatraman S Committed by Chris Ball
Browse files

mmc: omap_hsmmc: Convert critical failure reports to dev_err 



Fatal errors for the driver are not reported when just error debug
is enabled. Convert selected dev_dbg to dev_err for accurate error
reporting.

Reported-by: default avatarBenoit Cousson <b-cousson@ti.com>
Signed-off-by: default avatarVenkatraman S <svenkatr@ti.com>
Signed-off-by: default avatarChris Ball <cjb@laptop.org>
parent a48ce884

drivers/mmc/host/omap_hsmmc.c

+6 −6
Original line number Original line Diff line number Diff line
@@ -305,7 +305,7 @@ static int omap_hsmmc_reg_get(struct omap_hsmmc_host *host) 




	reg = regulator_get(host->dev, "vmmc");

	reg = regulator_get(host->dev, "vmmc");

	if (IS_ERR(reg)) {

	if (IS_ERR(reg)) {

		dev_dbg(host->dev, "vmmc regulator missing\n");

		dev_err(host->dev, "vmmc regulator missing\n");

		return PTR_ERR(reg);

		return PTR_ERR(reg);

	} else {

	} else {

		mmc_slot(host).set_power = omap_hsmmc_set_power;

		mmc_slot(host).set_power = omap_hsmmc_set_power;
@@ -1133,7 +1133,7 @@ static int omap_hsmmc_switch_opcond(struct omap_hsmmc_host *host, int vdd) 




	return 0;

	return 0;

err:

err:

	dev_dbg(mmc_dev(host->mmc), "Unable to switch operating voltage\n");

	dev_err(mmc_dev(host->mmc), "Unable to switch operating voltage\n");

	return ret;

	return ret;

}

}
@@ -1392,7 +1392,7 @@ omap_hsmmc_prepare_data(struct omap_hsmmc_host *host, struct mmc_request *req) 
	if (host->use_dma) {

	if (host->use_dma) {

		ret = omap_hsmmc_start_dma_transfer(host, req);

		ret = omap_hsmmc_start_dma_transfer(host, req);

		if (ret != 0) {

		if (ret != 0) {

			dev_dbg(mmc_dev(host->mmc), "MMC start dma failure\n");

			dev_err(mmc_dev(host->mmc), "MMC start dma failure\n");

			return ret;

			return ret;

		}

		}

	}

	}
@@ -1927,13 +1927,13 @@ static int __devinit omap_hsmmc_probe(struct platform_device *pdev) 
	ret = request_irq(host->irq, omap_hsmmc_irq, 0,

	ret = request_irq(host->irq, omap_hsmmc_irq, 0,

			mmc_hostname(mmc), host);

			mmc_hostname(mmc), host);

	if (ret) {

	if (ret) {

		dev_dbg(mmc_dev(host->mmc), "Unable to grab HSMMC IRQ\n");

		dev_err(mmc_dev(host->mmc), "Unable to grab HSMMC IRQ\n");

		goto err_irq;

		goto err_irq;

	}

	}





	if (pdata->init != NULL) {

	if (pdata->init != NULL) {

		if (pdata->init(&pdev->dev) != 0) {

		if (pdata->init(&pdev->dev) != 0) {

			dev_dbg(mmc_dev(host->mmc),

			dev_err(mmc_dev(host->mmc),

				"Unable to configure MMC IRQs\n");

				"Unable to configure MMC IRQs\n");

			goto err_irq_cd_init;

			goto err_irq_cd_init;

		}

		}
@@ -1956,7 +1956,7 @@ static int __devinit omap_hsmmc_probe(struct platform_device *pdev) 
					   IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_ONESHOT,

					   IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_ONESHOT,

					   mmc_hostname(mmc), host);

					   mmc_hostname(mmc), host);

		if (ret) {

		if (ret) {

			dev_dbg(mmc_dev(host->mmc),

			dev_err(mmc_dev(host->mmc),

				"Unable to grab MMC CD IRQ\n");

				"Unable to grab MMC CD IRQ\n");

			goto err_irq_cd;

			goto err_irq_cd;

		}

		}