Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b1a56b33 authored by Mark Brown's avatar Mark Brown
Browse files

ASoC: Remove bogus check for register validity in debugfs write 



Since not all registers need to be cached and the cache is entirely
optional anyway we shouldn't be checking that a register is in the
cached range. If the register is invalid then the actual I/O code
can determine that and report an error.

Similarly, the step size can and should be enforced by the lower level
code if it's important.

Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: default avatarLiam Girdwood <lrg@slimlogic.co.uk>
parent 2a3887f7

sound/soc/soc-core.c

+0 −2
Original line number Diff line number Diff line
@@ -259,8 +259,6 @@ static ssize_t codec_reg_write_file(struct file *file, 
	while (*start == ' ')

		start++;

	reg = simple_strtoul(start, &start, 16);

	if ((reg >= codec->driver->reg_cache_size) || (reg % step))

		return -EINVAL;

	while (*start == ' ')

		start++;

	if (strict_strtoul(start, 16, &value))