Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b19dd42f authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Frederic Weisbecker
Browse files

bkl: Remove locked .ioctl file operation 



The last user is gone, so we can safely remove this

Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Cc: John Kacur <jkacur@redhat.com>
Cc: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: default avatarFrederic Weisbecker <fweisbec@gmail.com>
parent c6d7ba8b

Documentation/filesystems/Locking

+1 −7
Original line number Diff line number Diff line
@@ -374,8 +374,6 @@ prototypes: 
	ssize_t (*aio_write) (struct kiocb *, const struct iovec *, unsigned long, loff_t);

	int (*readdir) (struct file *, void *, filldir_t);

	unsigned int (*poll) (struct file *, struct poll_table_struct *);

	int (*ioctl) (struct inode *, struct file *, unsigned int,

			unsigned long);

	long (*unlocked_ioctl) (struct file *, unsigned int, unsigned long);

	long (*compat_ioctl) (struct file *, unsigned int, unsigned long);

	int (*mmap) (struct file *, struct vm_area_struct *);
@@ -409,8 +407,7 @@ write: no 
aio_write:		no

readdir: 		no

poll:			no

ioctl:			yes	(see below)

unlocked_ioctl:		no	(see below)

unlocked_ioctl:		no

compat_ioctl:		no

mmap:			no

open:			no
@@ -453,9 +450,6 @@ move ->readdir() to inode_operations and use a separate method for directory 
anything that resembles union-mount we won't have a struct file for all

components. And there are other reasons why the current interface is a mess...



->ioctl() on regular files is superceded by the ->unlocked_ioctl() that

doesn't take the BKL.



->read on directories probably must go away - we should just enforce -EISDIR

in sys_read() and friends.

Documentation/filesystems/vfs.txt

+1 −5
Original line number Diff line number Diff line
@@ -727,7 +727,6 @@ struct file_operations { 
	ssize_t (*aio_write) (struct kiocb *, const struct iovec *, unsigned long, loff_t);

	int (*readdir) (struct file *, void *, filldir_t);

	unsigned int (*poll) (struct file *, struct poll_table_struct *);

	int (*ioctl) (struct inode *, struct file *, unsigned int, unsigned long);

	long (*unlocked_ioctl) (struct file *, unsigned int, unsigned long);

	long (*compat_ioctl) (struct file *, unsigned int, unsigned long);

	int (*mmap) (struct file *, struct vm_area_struct *);
@@ -768,10 +767,7 @@ otherwise noted. 
	activity on this file and (optionally) go to sleep until there

	is activity. Called by the select(2) and poll(2) system calls



  ioctl: called by the ioctl(2) system call



  unlocked_ioctl: called by the ioctl(2) system call. Filesystems that do not

  	require the BKL should use this method instead of the ioctl() above.

  unlocked_ioctl: called by the ioctl(2) system call.



  compat_ioctl: called by the ioctl(2) system call when 32 bit system calls

 	 are used on 64 bit kernels.

fs/bad_inode.c

+0 −7
Original line number Diff line number Diff line
@@ -55,12 +55,6 @@ static unsigned int bad_file_poll(struct file *filp, poll_table *wait) 
	return POLLERR;

}



static int bad_file_ioctl (struct inode *inode, struct file *filp,

			unsigned int cmd, unsigned long arg)

{

	return -EIO;

}



static long bad_file_unlocked_ioctl(struct file *file, unsigned cmd,

			unsigned long arg)

{
@@ -159,7 +153,6 @@ static const struct file_operations bad_file_ops = 
	.aio_write	= bad_file_aio_write,

	.readdir	= bad_file_readdir,

	.poll		= bad_file_poll,

	.ioctl		= bad_file_ioctl,

	.unlocked_ioctl	= bad_file_unlocked_ioctl,

	.compat_ioctl	= bad_file_compat_ioctl,

	.mmap		= bad_file_mmap,

fs/compat_ioctl.c

+1 −2
Original line number Diff line number Diff line
@@ -1699,8 +1699,7 @@ asmlinkage long compat_sys_ioctl(unsigned int fd, unsigned int cmd, 
				goto out_fput;

		}



		if (!filp->f_op ||

		    (!filp->f_op->ioctl && !filp->f_op->unlocked_ioctl))

		if (!filp->f_op || !filp->f_op->unlocked_ioctl)

			goto do_ioctl;

		break;

	}

fs/ioctl.c

+4 −14
Original line number Diff line number Diff line
@@ -29,7 +29,6 @@ 
 * @arg:	command-specific argument for ioctl

 *

 * Invokes filesystem specific ->unlocked_ioctl, if one exists; otherwise

 * invokes filesystem specific ->ioctl method.  If neither method exists,

 * returns -ENOTTY.

 *

 * Returns 0 on success, -errno on error.
@@ -39,21 +38,12 @@ static long vfs_ioctl(struct file *filp, unsigned int cmd, 
{

	int error = -ENOTTY;



	if (!filp->f_op)

	if (!filp->f_op || !filp->f_op->unlocked_ioctl)

		goto out;



	if (filp->f_op->unlocked_ioctl) {

	error = filp->f_op->unlocked_ioctl(filp, cmd, arg);

	if (error == -ENOIOCTLCMD)

		error = -EINVAL;

		goto out;

	} else if (filp->f_op->ioctl) {

		lock_kernel();

		error = filp->f_op->ioctl(filp->f_path.dentry->d_inode,

					  filp, cmd, arg);

		unlock_kernel();

	}



 out:

	return error;

}