Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b170204d authored by Andi Kleen's avatar Andi Kleen Committed by H. Peter Anvin
Browse files

x86, mce: drop BKL in mce_open 



BKL is not needed for anything in mce_open because it has
an own spinlock. Remove it.

[ Impact: cleanup ]

Signed-off-by: default avatarAndi Kleen <ak@linux.intel.com>
Signed-off-by: default avatarHidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Signed-off-by: default avatarH. Peter Anvin <hpa@zytor.com>
parent 32561696

arch/x86/kernel/cpu/mcheck/mce.c

+0 −4
Original line number Diff line number Diff line
@@ -13,7 +13,6 @@ 
#include <linux/ratelimit.h>

#include <linux/kallsyms.h>

#include <linux/rcupdate.h>

#include <linux/smp_lock.h>

#include <linux/kobject.h>

#include <linux/kdebug.h>

#include <linux/kernel.h>
@@ -791,12 +790,10 @@ static int open_exclu; /* already open exclusive? */ 


static int mce_open(struct inode *inode, struct file *file)

{

	lock_kernel();

	spin_lock(&mce_state_lock);



	if (open_exclu || (open_count && (file->f_flags & O_EXCL))) {

		spin_unlock(&mce_state_lock);

		unlock_kernel();



		return -EBUSY;

	}
@@ -806,7 +803,6 @@ static int mce_open(struct inode *inode, struct file *file) 
	open_count++;



	spin_unlock(&mce_state_lock);

	unlock_kernel();



	return nonseekable_open(inode, file);

}