Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b12bdaf1 authored by Brian Gerst's avatar Brian Gerst Committed by H. Peter Anvin
Browse files

x86: use regparm(3) for passed-in pt_regs pointer 



Some syscalls need to access the pt_regs structure, either to copy
user register state or to modifiy it.  This patch adds stubs to load
the address of the pt_regs struct into the %eax register, and changes
the syscalls to take the pointer as an argument instead of relying on
the assumption that the pt_regs structure overlaps the function
arguments.

Drop the use of regparm(1) due to concern about gcc bugs, and to move
in the direction of the eventual removal of regparm(0) for asmlinkage.

Signed-off-by: default avatarBrian Gerst <brgerst@gmail.com>
Signed-off-by: default avatarH. Peter Anvin <hpa@linux.intel.com>
parent 1c004004

arch/x86/include/asm/linkage.h

+0 −7
Original line number Diff line number Diff line
@@ -17,13 +17,6 @@ 
 */

#define asmregparm __attribute__((regparm(3)))



/*

 * For syscalls that need a pointer to the pt_regs struct (ie. fork).

 * The regs pointer is passed in %eax as the first argument.  The

 * remaining function arguments remain on the stack.

 */

#define ptregscall __attribute__((regparm(1)))



/*

 * Make sure the compiler doesn't do anything stupid with the

 * arguments on the stack - they are owned by the *caller*, not

arch/x86/include/asm/syscalls.h

+10 −15
Original line number Diff line number Diff line
@@ -29,26 +29,21 @@ asmlinkage int sys_get_thread_area(struct user_desc __user *); 
/* X86_32 only */

#ifdef CONFIG_X86_32

/* kernel/process_32.c */

ptregscall int sys_fork(struct pt_regs *);

ptregscall int sys_clone(struct pt_regs *, unsigned long,

			 unsigned long, int __user *,

			 unsigned long, int __user *);

ptregscall int sys_vfork(struct pt_regs *);

ptregscall int sys_execve(struct pt_regs *, char __user *,

			  char __user * __user *,

			  char __user * __user *);

int sys_fork(struct pt_regs *);

int sys_clone(struct pt_regs *);

int sys_vfork(struct pt_regs *);

int sys_execve(struct pt_regs *);



/* kernel/signal_32.c */

asmlinkage int sys_sigsuspend(int, int, old_sigset_t);

asmlinkage int sys_sigaction(int, const struct old_sigaction __user *,

			     struct old_sigaction __user *);

ptregscall int sys_sigaltstack(struct pt_regs *, const stack_t __user *,

			       stack_t __user *);

ptregscall unsigned long sys_sigreturn(struct pt_regs *);

ptregscall int sys_rt_sigreturn(struct pt_regs *);

int sys_sigaltstack(struct pt_regs *);

unsigned long sys_sigreturn(struct pt_regs *);

int sys_rt_sigreturn(struct pt_regs *);



/* kernel/ioport.c */

ptregscall long sys_iopl(struct pt_regs *, unsigned int);

long sys_iopl(struct pt_regs *);



/* kernel/sys_i386_32.c */

asmlinkage long sys_mmap2(unsigned long, unsigned long, unsigned long,
@@ -64,8 +59,8 @@ struct oldold_utsname; 
asmlinkage int sys_olduname(struct oldold_utsname __user *);



/* kernel/vm86_32.c */

ptregscall int sys_vm86old(struct pt_regs *, struct vm86_struct __user *);

ptregscall int sys_vm86(struct pt_regs *, unsigned long, unsigned long);

int sys_vm86old(struct pt_regs *);

int sys_vm86(struct pt_regs *);



#else /* CONFIG_X86_32 */

arch/x86/kernel/ioport.c

+2 −1
Original line number Diff line number Diff line
@@ -131,8 +131,9 @@ static int do_iopl(unsigned int level, struct pt_regs *regs) 
}



#ifdef CONFIG_X86_32

ptregscall long sys_iopl(struct pt_regs *regs, unsigned int level)

long sys_iopl(struct pt_regs *regs)

{

	unsigned int level = regs->bx;

	struct thread_struct *t = &current->thread;

	int rc;

arch/x86/kernel/process_32.c

+17 −10
Original line number Diff line number Diff line
@@ -603,15 +603,21 @@ __switch_to(struct task_struct *prev_p, struct task_struct *next_p) 
	return prev_p;

}



ptregscall int sys_fork(struct pt_regs *regs)

int sys_fork(struct pt_regs *regs)

{

	return do_fork(SIGCHLD, regs->sp, regs, 0, NULL, NULL);

}



ptregscall int sys_clone(struct pt_regs *regs, unsigned long clone_flags,

			 unsigned long newsp, int __user *parent_tidptr,

			 unsigned long unused, int __user *child_tidptr)

int sys_clone(struct pt_regs *regs)

{

	unsigned long clone_flags;

	unsigned long newsp;

	int __user *parent_tidptr, *child_tidptr;



	clone_flags = regs->bx;

	newsp = regs->cx;

	parent_tidptr = (int __user *)regs->dx;

	child_tidptr = (int __user *)regs->di;

	if (!newsp)

		newsp = regs->sp;

	return do_fork(clone_flags, newsp, regs, 0, parent_tidptr, child_tidptr);
@@ -627,7 +633,7 @@ ptregscall int sys_clone(struct pt_regs *regs, unsigned long clone_flags, 
 * do not have enough call-clobbered registers to hold all

 * the information you need.

 */

ptregscall int sys_vfork(struct pt_regs *regs)

int sys_vfork(struct pt_regs *regs)

{

	return do_fork(CLONE_VFORK | CLONE_VM | SIGCHLD, regs->sp, regs, 0, NULL, NULL);

}
@@ -635,18 +641,19 @@ ptregscall int sys_vfork(struct pt_regs *regs) 
/*

 * sys_execve() executes a new program.

 */

ptregscall int sys_execve(struct pt_regs *regs, char __user *u_filename,

			  char __user * __user *argv,

			  char __user * __user *envp)

int sys_execve(struct pt_regs *regs)

{

	int error;

	char *filename;



	filename = getname(u_filename);

	filename = getname((char __user *) regs->bx);

	error = PTR_ERR(filename);

	if (IS_ERR(filename))

		goto out;

	error = do_execve(filename, argv, envp, regs);

	error = do_execve(filename,

			(char __user * __user *) regs->cx,

			(char __user * __user *) regs->dx,

			regs);

	if (error == 0) {

		/* Make sure we don't return using sysenter.. */

		set_thread_flag(TIF_IRET);

arch/x86/kernel/signal.c

+14 −7
Original line number Diff line number Diff line
@@ -549,23 +549,27 @@ sys_sigaction(int sig, const struct old_sigaction __user *act, 
#endif /* CONFIG_X86_32 */



#ifdef CONFIG_X86_32

ptregscall int

sys_sigaltstack(struct pt_regs *regs, const stack_t __user *uss,

		stack_t __user *uoss)

int sys_sigaltstack(struct pt_regs *regs)

{

	const stack_t __user *uss = (const stack_t __user *)regs->bx;

	stack_t __user *uoss = (stack_t __user *)regs->cx;



	return do_sigaltstack(uss, uoss, regs->sp);

}

#else /* !CONFIG_X86_32 */

asmlinkage long

sys_sigaltstack(const stack_t __user *uss, stack_t __user *uoss,

		struct pt_regs *regs)

#endif /* CONFIG_X86_32 */

{

	return do_sigaltstack(uss, uoss, regs->sp);

}

#endif /* CONFIG_X86_32 */



/*

 * Do a signal return; undo the signal stack.

 */

#ifdef CONFIG_X86_32

ptregscall unsigned long sys_sigreturn(struct pt_regs *regs)

unsigned long sys_sigreturn(struct pt_regs *regs)

{

	struct sigframe __user *frame;

	unsigned long ax;
@@ -629,13 +633,16 @@ badframe: 
}



#ifdef CONFIG_X86_32

ptregscall int sys_rt_sigreturn(struct pt_regs *regs)

int sys_rt_sigreturn(struct pt_regs *regs)

{

	return do_rt_sigreturn(regs);

}

#else /* !CONFIG_X86_32 */

asmlinkage long sys_rt_sigreturn(struct pt_regs *regs)

#endif /* CONFIG_X86_32 */

{

	return do_rt_sigreturn(regs);

}

#endif /* CONFIG_X86_32 */



/*

 * OK, we're invoking a handler: