Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b0e95858 authored by Peter Hurley's avatar Peter Hurley Committed by Greg Kroah-Hartman
Browse files

tty: Clarify multiple-references comment in TIOCSETD ioctl 



Signed-off-by: default avatarPeter Hurley <peter@hurleysoftware.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e97733ca

drivers/tty/tty_ldisc.c

+6 −4
Original line number Diff line number Diff line
@@ -570,13 +570,15 @@ int tty_set_ldisc(struct tty_struct *tty, int ldisc) 
		tty_ldisc_restore(tty, old_ldisc);

	}



	/* At this point we hold a reference to the new ldisc and a

	   a reference to the old ldisc. If we ended up flipping back

	   to the existing ldisc we have two references to it */



	if (tty->ldisc->ops->num != old_ldisc->ops->num && tty->ops->set_ldisc)

		tty->ops->set_ldisc(tty);



	/* At this point we hold a reference to the new ldisc and a

	   reference to the old ldisc, or we hold two references to

	   the old ldisc (if it was restored as part of error cleanup

	   above). In either case, releasing a single reference from

	   the old ldisc is correct. */



	tty_ldisc_put(old_ldisc);



	/*